not done, give feedback what should i add